If you haven't already the first thing I would do is replace the clips even though they may appear to be in good cond. they loose tension and become brittle over time and if your molding is still not catching make sure it is not pushed in on the backside where the clip catches, there needs to be an even gap the full length.
I had a new windshield installed and also bought new aftermarket windshield molding because my upper had a slight bend ( of coarse only noticed by me) and they came with new clips and seals.
Though the clips were nearly indentical to my previous ones they were slightly thicker and taller ( hardly noticeable but made a difference) I ended up having to trim the bottoms because they were not seating all the way, I set them all to where the stud was at the end of the slot and also painted them all black since I have a black car with black trim.
Another thing I noticed is the mounting studs are symmetrical but the clips are not side specific which puts them on a different location on each side, further down on one side and higher on the other, I also had to slightly modify my new molding at the pass side upper corner to get the clip to catch correctly